Skip to content

Add new UI smoke tests #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: mainframe
Choose a base branch
from
Open

Add new UI smoke tests #300

wants to merge 3 commits into from

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Adding initial smoke test to footer, content, header, and sidebar.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Jul 3, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner July 3, 2025 17:34
@lamATnginx lamATnginx added the enhancement New feature or request label Jul 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/300/

@lamATnginx lamATnginx changed the title Added new UI smoke tests Add new UI smoke tests Jul 3, 2025
@TasoOneAsia
Copy link
Member

Nits:

  • Instead of page.locator("data-testid=sidebar__header") we can be more explicit and use page.getByTestId("sidebar__header")
  • Test names: "should render header" -> "renders header"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lamATnginx lamATnginx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @TasoOneAsia